Skip to content

[Misc] Clean up Qwen2.5-Omni code #17301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

DarkLight1337
Copy link
Member

Split up apply even more so that the override in Qwen2.5-Omni doesn't have to repeat as much code

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py April 28, 2025 10:55
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner April 28, 2025 10:55
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Apr 28, 2025
@Isotr0py Isotr0py enabled auto-merge (squash) April 28, 2025 11:07
@DarkLight1337 DarkLight1337 disabled auto-merge April 28, 2025 12:49
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 28, 2025 12:54
@vllm-bot vllm-bot merged commit 8b464d9 into vllm-project:main Apr 28, 2025
47 of 49 checks passed
@DarkLight1337 DarkLight1337 deleted the omni-cleanup branch April 28, 2025 13:20
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants