Skip to content

[Bugfix] Fix AttributeError: 'State' object has no attribute 'engine_client' #17434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Apr 30, 2025

Fix #17395

test

# python3 -m vllm.entrypoints.api_server --model Qwen/Qwen2.5-0.5B-Instruct --gpu-memory-utilization 0.95 --port 21131 --trust-remote-code
.....
INFO 04-30 03:08:01 [loader.py:458] Loading weights took 0.20 seconds
INFO 04-30 03:08:01 [gpu_model_runner.py:1353] Model loading took 0.9264 GiB and 1.655264 seconds
INFO 04-30 03:08:07 [backends.py:433] Using cache directory: /root/.cache/vllm/torch_compile_cache/0140516392/rank_0_0 for vLLM's torch.compile
INFO 04-30 03:08:07 [backends.py:443] Dynamo bytecode transform time: 5.92 s
INFO 04-30 03:08:11 [backends.py:118] Directly load the compiled graph(s) for shape None from the cache, took 3.840 s
INFO 04-30 03:08:12 [monitor.py:33] torch.compile takes 5.92 s in total
INFO 04-30 03:08:13 [kv_cache_utils.py:634] GPU KV cache size: 4,504,128 tokens
INFO 04-30 03:08:13 [kv_cache_utils.py:637] Maximum concurrency for 32,768 tokens per request: 137.46x
INFO 04-30 03:08:36 [gpu_model_runner.py:1697] Graph capturing finished in 22 secs, took 0.07 GiB
INFO 04-30 03:08:36 [core.py:159] init engine (profile, create kv cache, warmup model) took 34.43 seconds
INFO 04-30 03:08:36 [core_client.py:439] Core engine process 0 ready.
INFO 04-30 03:08:36 [launcher.py:28] Available routes are:
INFO 04-30 03:08:36 [launcher.py:36] Route: /openapi.json, Methods: HEAD, GET
INFO 04-30 03:08:36 [launcher.py:36] Route: /docs, Methods: HEAD, GET
INFO 04-30 03:08:36 [launcher.py:36] Route: /docs/oauth2-redirect, Methods: HEAD, GET
INFO 04-30 03:08:36 [launcher.py:36] Route: /redoc, Methods: HEAD, GET
INFO 04-30 03:08:36 [launcher.py:36] Route: /health, Methods: GET
INFO 04-30 03:08:36 [launcher.py:36] Route: /generate, Methods: POST
INFO:     Started server process [3311606]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://0.0.0.0:21131 (Press CTRL+C to quit)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Apr 30, 2025
@chaunceyjiang
Copy link
Contributor Author

@russellb @DarkLight1337 PTAL.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@vllm-bot vllm-bot merged commit be633fb into vllm-project:main Apr 30, 2025
27 checks passed
@chaunceyjiang chaunceyjiang deleted the engine_client branch April 30, 2025 08:07
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
dtrifiro pushed a commit to red-hat-data-services/vllm that referenced this pull request May 13, 2025
dtrifiro pushed a commit to red-hat-data-services/vllm that referenced this pull request May 13, 2025
Syncing midstream NM fork to Upstream tag of
[v0.8.5.post1](https://github.com/vllm-project/vllm/tree/v0.8.5.post1) +
cherry pick of
vllm-project@be633fb
needed for benchmarks +
[CP](neuralmagic/nm-vllm-ent@1fe447d)
for compressed tensor bump +
[CP](vllm-project#17677) for lora on AMD +
[CP](vllm-project#17315) for llama4 w/ pure
dense layers

```
commit 31c73ba (HEAD -> upstream-v0.8.5, nm-fork/upstream-v0.8.5)
Author: Chauncey <[email protected]>
Date:   Wed Apr 30 15:11:04 2025 +0800

    [Bugfix] Fix AttributeError: 'State' object has no attribute 'engine_client' (vllm-project#17434)
    
    Signed-off-by: chaunceyjiang <[email protected]>

commit f8db0bd
Author: Lucas Wilkinson <[email protected]>
Date:   Fri May 2 14:01:38 2025 -0400

    [BugFix][Attention] Fix sliding window attention in V1 giving incorrect results (vllm-project#17574)
    
    Signed-off-by: Lucas Wilkinson <[email protected]>

commit e335c34
Author: Robert Shaw <[email protected]>
Date:   Fri May 2 04:07:03 2025 -0400

    [BugFix] Fix Memory Leak (vllm-project#17567)
    
    Signed-off-by: [email protected] <[email protected]>

commit cc463fe
Merge: 1e358ff ba41cc9
Author: Selbi Nuryyeva <[email protected]>
Date:   Tue Apr 29 12:34:57 2025 -0400

    Merge branch 'tag-upstream-v0.8.5' into upstream-v0.8.5

commit ba41cc9 (tag: v0.8.5, tag-upstream-v0.8.5)
Author: Michael Goin <[email protected]>
Date:   Mon Apr 28 16:20:24 2025 -0600

    [Model] Add tuned triton fused_moe configs for Qwen3Moe (vllm-project#17328)
    
    Signed-off-by: mgoin <[email protected]>

commit dcbac4c
Author: Simon Mo <[email protected]>
Date:   Mon Apr 28 14:12:01 2025 -0700

    [Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
    
    Signed-off-by: simon-mo <[email protected]>
[...]
```

Commands
```
git fetch upstream
git checkout -b upstream-v0.8.5
git merge upstream/v0.8.5
git cherry-pick be633fb
```

TEST PLAN
accept sync:
https://github.com/neuralmagic/nm-cicd/actions/runs/14841223552
related PR in cicd: neuralmagic/nm-cicd#99
release workflow:
https://github.com/neuralmagic/nm-cicd/actions/runs/14845693864
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@IamMegatron2025
Copy link

version 0.8.5 still has this problem.

@DarkLight1337
Copy link
Member

DarkLight1337 commented May 30, 2025

This fix is only included in v0.9.0 or later

minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: vllm.entrypoints.api_server throw exception when startup in v0.8.5
4 participants