Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

Conversation

@JoelMon
Copy link

@JoelMon JoelMon commented Jul 6, 2022

Fixed issue #37

metadata.permissions() does not contain a mode() method, only a .readonly() method. It does have a trait PermitionExt but it is only supported for Unix systems.

tin-summer now builds and runs on Windows and test passed.

@JoelMon
Copy link
Author

JoelMon commented Jul 6, 2022

Just cleaned out my dev dir with sn. 20gigs down to 3 gigs. :D

@thearian
Copy link

thearian commented May 2, 2023

Hey, nice work! May I just introduce a better solution?
Changing the 755 to readonly is not precise in Unix.
755 permission mode is not quite the readonly that we have in windows as mentioned here despite the fact that it works 99% of the time on all systems.

It just would be much nicer if there was the Unix implementation alongside our readonly solution.

I opened a pull request just before finding your PR but just wanted to note on your work, too.

@JoelMon
Copy link
Author

JoelMon commented Jul 4, 2024

@thearian That's wonderful, thank you for pointing that out.

@JoelMon JoelMon closed this Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants