UI: Helm values not correctly reported

[dud225]

Hello

I've initially deployed Kubeapps with a long Helm command that happened to add some Nginx annotations:

--set ingress.annotations."nginx\.ingress\.kubernetes\.io/auth-response-headers"=Authorization \
--set ingress.annotations."nginx\.ingress\.kubernetes\.io/auth-signin"='https://$host/oauth2/start?rd=$escaped_request_uri' \
--set ingress.annotations."nginx\.ingress\.kubernetes\.io/auth-url"=http://oauth2-proxy.kube-system.svc.cluster.local/oauth2/auth \
--set ingress.annotations."nginx\.ingress\.kubernetes\.io/configuration-snippet"='rewrite ^(/kubeapps)$ $1/ redirect;' \
--set ingress.annotations."nginx\.ingress\.kubernetes\.io/rewrite-target"='/$upstream_path' \

However those settings are not correctly reported within Kubeapps:

which makes it unhappy when deploying:

Manually adjusting the values in the UI allows the deployment to succeed.

[antgamdia]

Hi Hervé, thanks for reporting it. I'll have a look using the current version in the main branch (as we performed some changes in the AppUpgrade view). However, it could be an actual issue derived from the parsing from yaml <-> json, so it is worth checking.

[antgamdia]

Confirming it's an issue we can reproduce. I guess it is something wrong with the parser at one of the ends. Thanks again for letting us know :)

The problematic snippet should be either:

a) Using curly braces BUT with quoted values.

  annotations:
    {
      kubernetes.io/ingress.class: nginx,
      nginx.ingress.kubernetes.io/auth-response-headers: "Authorization",
      nginx.ingress.kubernetes.io/auth-signin: "https://$host/aaa/start?rd=$escaped_request_uri",
      nginx.ingress.kubernetes.io/auth-url: "http://aaa-proxy.kube-system.svc.cluster.local/oauth2/auth",
      nginx.ingress.kubernetes.io/configuration-snippet: "rewrite ^(/aaa)$ $1/ redirect;",
      nginx.ingress.kubernetes.io/rewrite-target: "/$upstream_path"
    }

or

b) not using curly braces at all

  annotations:
      kubernetes.io/ingress.class: nginx,
      nginx.ingress.kubernetes.io/auth-response-headers: Authorization,
      nginx.ingress.kubernetes.io/auth-signin: https://$host/aaa/start?rd=$escaped_request_uri,
      nginx.ingress.kubernetes.io/auth-url: http://aaa-proxy.kube-system.svc.cluster.local/oauth2/auth,
      nginx.ingress.kubernetes.io/configuration-snippet: rewrite ^(/aaa)$ $1/ redirect;,
      nginx.ingress.kubernetes.io/rewrite-target: /$upstream_path

I'd say the issue is around https://github.com/kubeapps/kubeapps/blob/master/dashboard/src/components/UpgradeForm/UpgradeForm.tsx#L107, but I don't have the bandwidth to closely look at it at the moment.

After looking into it a little bit, I'd say it is caused by the usage of two different YAML parsers in the frontend: js-yaml and yaml, so there could be some little differences in the implementation leading to this error.

An ugly and quick hotfix is replacing:
https://github.com/kubeapps/kubeapps/blob/30ced3aacf4b274f07fbf84d3b7d0691c6be4367/dashboard/src/components/UpgradeForm/UpgradeForm.tsx#L39

with:

  return values.replaceAll("{", "")?.replaceAll("}", "");

If anyone is interested in giving it a try, I'm happy to walk them through it.