This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Update chart.RegistrySecretsPerDomain to depend on kube clientset only.#3362
Merged
Conversation
Signed-off-by: Michael Nelson <minelson@vmware.com>
antgamdia
approved these changes
Sep 7, 2021
Contributor
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Neat! Thanks for the change, happy to see we are just passing the ctx instead instead of manually pass the cluster, token etc...
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a spin-off change for supporting CreateInstalledPackage via the new kubeapps apis. I don't want the new kubeapps-apis to need to deal with the
kube.handlerabstraction, since our plugins don't even see the user token, nor should they need to know about them.Benefits
The RegistrySecretsPerDomain function depends on less code.
Possible drawbacks
None known.
Applicable issues
Additional information