Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Pass asset-syncer img as an ENV var#3409

Merged
antgamdia merged 1 commit into
vmware-tanzu:masterfrom
antgamdia:assetsyncAsEnv
Sep 14, 2021
Merged

Pass asset-syncer img as an ENV var#3409
antgamdia merged 1 commit into
vmware-tanzu:masterfrom
antgamdia:assetsyncAsEnv

Conversation

@antgamdia
Copy link
Copy Markdown
Contributor

@antgamdia antgamdia commented Sep 13, 2021

Description of the change

This PR is just to pass the asset-syncer job image as an ENV var.

Benefits

Kubeapps is closer to being built as a Carvel pkg.

Possible drawbacks

N/A

Applicable issues

Additional information

If accepted, then sync with the Content team to check if any further changes are required in their internal tooling.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Copy Markdown
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@antgamdia
Copy link
Copy Markdown
Contributor Author

Merging as it is green (https://app.circleci.com/pipelines/github/antgamdia/kubeapps/1149/workflows/4e55fc4c-6c9a-4634-9d12-2df09ff2f925) but not reported due to a circleci (internal) issue this morning.

@antgamdia antgamdia merged commit 7fd38c9 into vmware-tanzu:master Sep 14, 2021
@antgamdia antgamdia deleted the assetsyncAsEnv branch September 14, 2021 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass asset-syncer job image through ENV vars to work with kbld

2 participants