This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Add versions - kubeops#3441
Merged
Merged
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
7 tasks
antgamdia
commented
Sep 20, 2021
| RUN --mount=type=cache,target=/go/pkg/mod \ | ||
| --mount=type=cache,target=/root/.cache/go-build \ | ||
| CGO_ENABLED=0 go build -installsuffix cgo -ldflags "-X main.version=$VERSION" ./cmd/kubeops | ||
| CGO_ENABLED=0 go build -installsuffix cgo -ldflags "-X github.com/kubeapps/kubeapps/cmd/kubeops/cmd.version=$VERSION" ./cmd/kubeops |
Contributor
Author
There was a problem hiding this comment.
Got it from: go tool nm ./kubeops | grep cmd.version
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds the
--versioncommand tokubeopsBesides, it also adapts the code to the latest cobra boilerplate, so that all of our binaries are similar.
Benefits
Our binaries will properly display their version
Possible drawbacks
N/A
Applicable issues
--versionto all of our binaries #3429Additional information
Testing with: