This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Remove unused code#3498
Merged
Merged
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
After bumping Helm up to 3.7.0, we are able to also upgrade Oras and containerd Removing Helm2 also implies some minor changes in our code Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
This was referenced Sep 24, 2021
Closed
absoludity
approved these changes
Oct 6, 2021
Contributor
absoludity
left a comment
absoludity
left a comment
There was a problem hiding this comment.
Excellent. Glad to see references to proxy gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Due to the memory issues faced in #3483 (comment), this PR aims at solving just a single: removing the old references to Helm2 as well as other unused code.
This action is required before we update the go deps to avoid deps conflicts.
Benefits
The root of the memory issue perhaps will arise.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
This is not the same code as in #3483; I've replaced
response.NewDataResponse(rel).Write(w)withresponse.NewDataResponse(*rel).Write(w), since I'm thinking it could be the cause. Not verified, though, just sending the PR to see if it is OOMKilled.