This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Duplicated - fix(upgrade): Fetch package from its installed cluster#3545
Closed
antgamdia wants to merge 2 commits into
Closed
Duplicated - fix(upgrade): Fetch package from its installed cluster#3545antgamdia wants to merge 2 commits into
antgamdia wants to merge 2 commits into
Conversation
Contributor
Author
|
Closing as the initial PR was merged (it was just a transient CI issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit(antgamdia): duplicating PR from our branch to avoid some permission-related issues after the forked repo was migrated to another repository. If CI passes, this PR should be ready to be merged. -- all credits of this PR should go to .aanthonyrizzo
PR comments at #3525
Description of the change
This PR addresses (what I think is a bug) regarding the fetching of Packages when upgrading.
Current behavior
When navigating to the upgrade form for deployments that are installed in the
"default"cluster. The upgrade form fails to fetch the applicable package details if it is looking in the wrong cluster.New behavior
When fetching the package details, we use the cluster that is defined in the
AvailablePackageDetailproperty when fetching the package. This should lead to correct fetching behavior.Benefits
Global packages that are installed in the
""cluster but are deployed in the"default"can now be upgraded.Possible drawbacks
I don't believe there are any.
Applicable issues
I did not create an issue since I was experimenting w/ solutions locally and seemed to have solved it.
Additional information
I believe this is a relatively impactful bug that is present in 05775ff and should be addressed before the next major release. I have not pinpointed the exact commit that broke this behavior.
.antgamdia .absoludity for visibility