This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Enforce css alpha values as numbers#3654
Merged
Merged
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Oct 25, 2021
Contributor
absoludity
left a comment
There was a problem hiding this comment.
I'm assuming that the .stylelintrc.json is the only change for review here (the rest being generated?)
Contributor
Author
Yes, sure, the rest is autogenerated via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the stylelint rules to enforce the usage of numeric alpha (like in the
opacityproperty) values. This change would fix #3653.Additionally, it extends another config that performs an auto-sort of the CSS properties for the sake of uniformity.
Benefits
The opacity will return back to normal in our built postprocessed css.
Possible drawbacks
N/A
Applicable issues
Additional information
I don't know the actual root issue; I mean, the opacity as percentages are widely supported in most browsers (eg in chrome from v78), so I don't see why it wasn't been properly rendered. Maybe it was due to a misconfiguration in our sass compiler?
Anyway, I can confirm it works after having built a custom dashboard image: