Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Enforce css alpha values as numbers#3654

Merged
antgamdia merged 2 commits into
vmware-tanzu:masterfrom
antgamdia:stylelint-fix
Oct 26, 2021
Merged

Enforce css alpha values as numbers#3654
antgamdia merged 2 commits into
vmware-tanzu:masterfrom
antgamdia:stylelint-fix

Conversation

@antgamdia
Copy link
Copy Markdown
Contributor

Description of the change

This PR updates the stylelint rules to enforce the usage of numeric alpha (like in the opacity property) values. This change would fix #3653.
Additionally, it extends another config that performs an auto-sort of the CSS properties for the sake of uniformity.

Benefits

The opacity will return back to normal in our built postprocessed css.

Possible drawbacks

N/A

Applicable issues

Additional information

I don't know the actual root issue; I mean, the opacity as percentages are widely supported in most browsers (eg in chrome from v78), so I don't see why it wasn't been properly rendered. Maybe it was due to a misconfiguration in our sass compiler?

Anyway, I can confirm it works after having built a custom dashboard image:

image

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Copy Markdown
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the .stylelintrc.json is the only change for review here (the rest being generated?)

@antgamdia
Copy link
Copy Markdown
Contributor Author

I'm assuming that the .stylelintrc.json is the only change for review here (the rest being generated?

Yes, sure, the rest is autogenerated via yarn lint-css command. Well, there is a simple new package added, which is just new stylelint config, but that's all.

@antgamdia antgamdia merged commit 86c7153 into vmware-tanzu:master Oct 26, 2021
@antgamdia antgamdia deleted the stylelint-fix branch October 26, 2021 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right menu not being displayed

2 participants