This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Two documentation uses of enable that I missed in #3590#3710
Merged
Conversation
Signed-off-by: Michael Nelson <minelson@vmware.com>
antgamdia
approved these changes
Nov 9, 2021
Contributor
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Thanks for catching it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Just two cases of
enablethat I missed, in the documentation for pinniped-proxy setup.Just noticed while pointing someone else at the docs.
Benefits
When we do the next release, people will use the consistent key rather than the deprecated key..
Possible drawbacks
Until we release, people need to use the old key (the new release will support both for now).
For this reason, I'll not land this change until we release.
Applicable issues
PinnipedConfig.Enabledflag name for consistency. #3590Additional information