This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Add to Github actions the first Custodian rule check for unattached disks#4449
Merged
Conversation
added 3 commits
March 16, 2022 11:45
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Contributor
Author
|
First run shows 81 disks removed! 🥳 2022-03-16 09:58:21,233: custodian.policy:INFO policy:remove-unattached-disks resource:gcp.disk region: count:81 time:0.54
2022-03-16 09:58:46,392: custodian.policy:INFO policy:remove-unattached-disks action:diskdelete resources:81 execution_time:25.16 |
castelblanque
changed the title
castelblanque
changed the title
antgamdia
approved these changes
Mar 16, 2022
Contributor
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Wow, thank you!! 81 disks we weren't aware of! Great tool!
And... our first github action!
Contributor
Author
Yeah, it is really good news! 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
With this PR, a cronjob is set to check every day at 8AM that there no unattached disks in the GCloud project used for CI when releasing.
It makes use of the Custodian rule provided by Jorge Bianquetti, plus the use of the available Cloud Custodian Github action.
Benefits
No unused, unattached disks will live more than 1 day. This saves money from cloud infrastructure invoice.
Applicable issues
Additional information
A couple of secrets are created: