This repository was archived by the owner on Jan 13, 2026. It is now read-only.
logs if helm repo empty instead throws error#4682
Merged
Merged
Conversation
absoludity
approved these changes
May 10, 2022
Contributor
absoludity
left a comment
absoludity
left a comment
There was a problem hiding this comment.
Excellent, thanks for jumping in to fix it @hzliangbin .
absoludity
suggested changes
May 10, 2022
Contributor
absoludity
left a comment
absoludity
left a comment
There was a problem hiding this comment.
Sorry @hzliangbin , could you please add the DCO sign-off to your commit? Instructions for how to do this are at https://github.com/vmware-tanzu/kubeapps/blob/main/CONTRIBUTING.md#dco-sign-off
Thanks!
Signed-off-by: Bin Liang <hzliangbin@foxmail.com>
Contributor
Author
|
@absoludity PTAL |
absoludity
approved these changes
May 11, 2022
Contributor
absoludity
left a comment
absoludity
left a comment
There was a problem hiding this comment.
Excellent, thanks @hzliangbin :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
just print logs if helm repo empty instead throws error
Benefits
sync job will come to a Compelte state instead of error, it's more user-friendly
Possible drawbacks
Applicable issues
Additional information