Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Add minor improvements prior to the repos UI#4848

Merged
antgamdia merged 6 commits into
mainfrom
pkgRepo-pre2
Jun 6, 2022
Merged

Add minor improvements prior to the repos UI#4848
antgamdia merged 6 commits into
mainfrom
pkgRepo-pre2

Conversation

@antgamdia
Copy link
Copy Markdown
Contributor

Description of the change

As part of the work required for #4764, this prequel PR adds minor stuff that I can easily have taken apart from my ongoing changes. Namely:

  • Related to the Repos UI:
    • Add more information to the core API logs
    • Add more str cases in getPluginPackageName
    • Add repos api clients to KubeappsGrpcClient
  • Minor unrelated improvements
    • Handle uncaught canI rejections
    • Remove "as unknown" in some types
    • Return 0 if equals in a sort function

Benefits

Subsequent PRs will have less code to review :P

Possible drawbacks

N/A

Applicable issues

Additional information

The changes are pretty unrelated to the actual repos API things, as they are mainly improvements on other parts of the code.

antgamdia added 6 commits June 6, 2022 12:48
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2022

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit f95eb6a
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/629deed0aed8e7000880693b

@castelblanque
Copy link
Copy Markdown
Contributor

Great, thanks for the preparation work!

@antgamdia antgamdia merged commit 23e9605 into main Jun 6, 2022
@antgamdia antgamdia deleted the pkgRepo-pre2 branch June 6, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants