Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

New deployment timeout for Operators#4851

Merged
castelblanque merged 1 commit into
mainfrom
4832-operators-e2e-tests
Jun 7, 2022
Merged

New deployment timeout for Operators#4851
castelblanque merged 1 commit into
mainfrom
4832-operators-e2e-tests

Conversation

@castelblanque
Copy link
Copy Markdown
Contributor

Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com

Description of the change

Simply set global deployment timeout for test when deploying an operator.
Reasoning behind is that e2e tests where randomly failing due to operator not yet ready when the test continued after the waiting timeout.

Did 10 runs on CircleCI that can be checked here. None of those failed.

Benefits

E2E test should not fail, at least not that often.

Possible drawbacks

E2E may take a little more time, but due to operators being deployed actually.

Applicable issues

Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@castelblanque castelblanque marked this pull request as ready for review June 6, 2022 16:10
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2022

Deploy Preview for kubeapps-dev ready!

Name Link
🔨 Latest commit 6a63ec4
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/629e26f585a2280008cd325d
😎 Deploy Preview https://deploy-preview-4851--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for testing it! Let's see if it improves the reliability

@castelblanque castelblanque merged commit 9ac55f0 into main Jun 7, 2022
@castelblanque castelblanque deleted the 4832-operators-e2e-tests branch June 7, 2022 06:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operators e2e test randomly failing

3 participants