Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Add namespace information to AppListItem#4912

Merged
antgamdia merged 2 commits into
vmware-tanzu:mainfrom
smerschjohann:smerschjohann/issue4896
Jun 15, 2022
Merged

Add namespace information to AppListItem#4912
antgamdia merged 2 commits into
vmware-tanzu:mainfrom
smerschjohann:smerschjohann/issue4896

Conversation

@smerschjohann
Copy link
Copy Markdown
Contributor

Description of the change

It adds the Namespace to the description in the AppViewItem

Benefits

One can differentiate the installed packages of different namespaces

Possible drawbacks

none

Applicable issues

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 13, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ba620d
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62a99ea020b789000afe767d

@vmwclabot
Copy link
Copy Markdown

@smerschjohann, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@smerschjohann smerschjohann force-pushed the smerschjohann/issue4896 branch from 9e2eb83 to a239b20 Compare June 13, 2022 19:52
Copy link
Copy Markdown
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM. Thanks for the contribution. We are currently having some issues with the CI system (see #4832), but once resolved on our side, we'll merge it so that it gets released in the upcoming v2.4.6.

@smerschjohann
Copy link
Copy Markdown
Contributor Author

Awesome, LGTM. Thanks for the contribution. We are currently having some issues with the CI system (see #4832), but once resolved on our side, we'll merge it so that it gets released in the upcoming v2.4.6.

Yeah, I saw that already. It was a bit complicated, to find out that those were different failures and had nothing todo with my commit. But, I figured that out already ;) I'm looking forward to it :)

@antgamdia antgamdia merged commit 7d072e2 into vmware-tanzu:main Jun 15, 2022
@vmwclabot
Copy link
Copy Markdown

@smerschjohann, VMware has approved your signed contributor license agreement.

@smerschjohann smerschjohann deleted the smerschjohann/issue4896 branch June 22, 2022 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add namespace information to AppListItem

3 participants