This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Changed order of installing ChartMuseum in E2E tests#5236
Merged
Conversation
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
approved these changes
Aug 25, 2022
Contributor
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Great! The previous refactor made it trivial!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR changes the E2E execution logic to install first chart museum and then Kubeapps. Before, Kubeapps was being installed before. It could be rare, but in some situations, ChartMuseum could not be ready for Kubeapps.
After the refactoring done in #5143 it has been easier to implement this change, for example the namespace was already the right one,
chart-museum.Benefits
Right installation order of E2E elements.
Possible drawbacks
N/A
Applicable issues