Fix for GKE CI pipeline#5428
Conversation
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
| while [ -z $LB_IP ]; do | ||
| echo "Waiting for external IP" | ||
| LB_IP=$(kubectl -n nginx-ingress get service nginx-ingress-ingress-nginx-controller --template="{{range .status.loadBalancer.ingress}}{{.ip}}{{end}}") | ||
| [ -z "$LB_IP" ] && sleep 10 | ||
| done |
There was a problem hiding this comment.
Ideally we would like this to have a max retries limitation.
There was a problem hiding this comment.
yeah, I think we should add it to avoid potential headaches 😄
There was a problem hiding this comment.
There is the timeout of the pipeline run itself that will kick in for now. Will try to tackle it in a further PR.
| echo "Instaling Nginx" | ||
| helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx | ||
| helm repo update | ||
| helm install -n nginx-ingress --create-namespace nginx-ingress ingress-nginx/ingress-nginx |
There was a problem hiding this comment.
I guess we don't need the annotations we use to add for Kubeapps itself, no?
There was a problem hiding this comment.
Do you mean the buffers setup? Not sure what values come installing Nginx with Helm.
If annotations don't cause harm, I would leave them by now.
This branch already contains the GH pipeline. It is actually failing at one step: |
| while [ -z $LB_IP ]; do | ||
| echo "Waiting for external IP" | ||
| LB_IP=$(kubectl -n nginx-ingress get service nginx-ingress-ingress-nginx-controller --template="{{range .status.loadBalancer.ingress}}{{.ip}}{{end}}") | ||
| [ -z "$LB_IP" ] && sleep 10 | ||
| done |
There was a problem hiding this comment.
yeah, I think we should add it to avoid potential headaches 😄
Co-authored-by: Jesús Miguel Benito Calzada <bjesus@vmware.com> Signed-off-by: Rafa Castelblanque <67455978+castelblanque@users.noreply.github.com>
At this moment, the GKE-related jobs haven't been migrated to the GHA workflow, so these changes shouldn't affect it. |
|
Merging, as only one step of new GH actions pipeline is failing ( |
4 participants
Description of the change
This PR fixes the CI pipeline in GKE at the point of accesing the Chart Museum.
In #5337, an ingress was added to use Chart Museum, instead of using a
port-forward.Nginx ingress is installed in the Kind clusters created, but not on GKE cluster. Hence this PR.
Example of passing GKE pipeline.
Benefits
GKE CI pipelines will work with chart museum without
port-forward.Possible drawbacks
Chart museum will be exposed through an Ingress in GKE clusters while testing. But Chart museum itself has authentication, so it should not be a problem.
Applicable issues