Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Use GitHub Actions' environment file for steps' outputs#5464

Merged
beni0888 merged 1 commit into
vmware-tanzu:mainfrom
beni0888:use-env-file-for-outputs
Oct 17, 2022
Merged

Use GitHub Actions' environment file for steps' outputs#5464
beni0888 merged 1 commit into
vmware-tanzu:mainfrom
beni0888:use-env-file-for-outputs

Conversation

@beni0888
Copy link
Copy Markdown
Collaborator

@beni0888 beni0888 commented Oct 17, 2022

Signed-off-by: Jesús Benito Calzada bjesus@vmware.com

Description of the change

According to a recent GitHub post, set-output and save-state commands have been deprecated and corresponding environment files should be used instead.

Benefits

  • Remove the use of deprecated GitHub Actions' commands and follow best practices.
  • The pipeline is more secure.

Possible drawbacks

None.

Applicable issues

Additional information

Use GitHub Actions' environment file for steps' outputs
cd64fb5 
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@beni0888 beni0888 added component/ci Issue related to kubeapps ci system kind/enhancement An issue that reports an enhancement for an implemented feature security Issues which relate to security concerns. github_actions Pull requests that update GitHub Actions code labels Oct 17, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Oct 17, 2022
@beni0888 beni0888 self-assigned this Oct 17, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 17, 2022 •
edited
Loading

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit cd64fb5
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/634cedb7cea0290008fe5d55

@beni0888 beni0888 marked this pull request as ready for review October 17, 2022 05:53
castelblanque
castelblanque approved these changes Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@beni0888 beni0888 merged commit bb443bb into vmware-tanzu:main Oct 17, 2022
@beni0888 beni0888 deleted the use-env-file-for-outputs branch October 17, 2022 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@absoludity absoludity Awaiting requested review from absoludity

@antgamdia antgamdia Awaiting requested review from antgamdia

1 more reviewer

@castelblanque castelblanque castelblanque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beni0888 beni0888

Labels

cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code kind/enhancement An issue that reports an enhancement for an implemented feature security Issues which relate to security concerns.

Projects

Kubeapps
Status: ✅ Done

Milestone

Migrate CI to GitHub Actions

Development

Successfully merging this pull request may close these issues.

3 participants

@beni0888 @castelblanque @vmwclabot