rm chart value 'allowNamespaceDiscovery' fixing issue #5422#5574
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
|
@giulianopz, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@giulianopz, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
Thanks for your contribution, @giulianopz . Please, have a look at this project we are using to auto-generate the readme: https://github.com/bitnami-labs/readme-generator-for-helm. Then, run it and update the README.md with the change you performed in the values.yaml file. |
There was a problem hiding this comment.
Thanks for using the tool I suggested to autogenerate the readme file. Find below just a couple of minor changes before merging the PR (mainly removing some unwanted changes). Apart from that, +1.
Also, a github action check is currently failing; we are working to fix it, it's not your PR's fault :P
| - [Kubeapps packaged by Bitnami](#kubeapps-packaged-by-bitnami) | ||
| - [TL;DR](#tldr) | ||
| - [Introduction](#introduction) | ||
| - [Prerequisites](#prerequisites) | ||
| - [Installing the Chart](#installing-the-chart) | ||
| - [Parameters](#parameters) | ||
| - [Global parameters](#global-parameters) | ||
| - [Common parameters](#common-parameters) | ||
| - [Traffic Exposure Parameters](#traffic-exposure-parameters) | ||
| - [Kubeapps packaging options](#kubeapps-packaging-options) | ||
| - [Frontend parameters](#frontend-parameters) | ||
| - [Dashboard parameters](#dashboard-parameters) | ||
| - [AppRepository Controller parameters](#apprepository-controller-parameters) | ||
| - [Auth Proxy parameters](#auth-proxy-parameters) | ||
| - [Pinniped Proxy parameters](#pinniped-proxy-parameters) | ||
| - [Other Parameters](#other-parameters) | ||
| - [Feature flags](#feature-flags) | ||
| - [Database Parameters](#database-parameters) | ||
| - [kubeappsapis parameters](#kubeappsapis-parameters) | ||
| - [Redis® chart configuration](#redis-chart-configuration) | ||
| - [Configuration and installation details](#configuration-and-installation-details) | ||
| - [Configuring Initial Repositories](#configuring-initial-repositories) | ||
| - [Enabling Operators](#enabling-operators) | ||
| - [Exposing Externally](#exposing-externally) | ||
| - [LoadBalancer Service](#loadbalancer-service) | ||
| - [Ingress](#ingress) | ||
| - [Hosts](#hosts) | ||
| - [Annotations](#annotations) | ||
| - [TLS](#tls) | ||
| - [Upgrading Kubeapps](#upgrading-kubeapps) | ||
| - [Uninstalling the Chart](#uninstalling-the-chart) |
There was a problem hiding this comment.
I don't think we need to add these changes, we only want to keep the FAQ section, not the whole table of contents of the readme at this point. Please, revert these changes
| @@ -1,125 +1,2886 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/schema#", | |||
There was a problem hiding this comment.
Thanks for using the tool to also generate the underlying JSON schema. That said, currently we don't want to use this schema. Just for you to know, in the latest v2.6.0 release, we migrated to full json schema based form. Along with this chance, the Bitnami Application Catalog is gonna autogenerate the schemas using this tool soon. Hence, we want to switch the schema once they also perform the change. Hope it makes sense for you.
In short, please revert the changes in this file.
Unwanted changes reverted as requested. |
antgamdia
left a comment
antgamdia
left a comment
There was a problem hiding this comment.
Great, thanks for your contribution :)
|
@giulianopz , there's an additional pending thing. According to our contributing guidelines, all the commits must be signed. If you face any problems, happy to assist via slack. Let's try to get it to merge before the end of October, so that it can count for the hacktoberfest! [1] https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Signed-off-by: giuliano <panzironi.giuliano@gmail.com>
Signed-off-by: giuliano <panzironi.giuliano@gmail.com>
Signed-off-by: giuliano <panzironi.giuliano@gmail.com>
Signed-off-by: giuliano <panzironi.giuliano@gmail.com>
Never done before. Happy that contributing to a simple issue taught me a couple of things. Thanks! |
|
Thank you! LGTM, merging straight away :) |
|
@giulianopz, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement. |
|
@giulianopz, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@giulianopz, VMware has approved your signed contributor license agreement. |
3 participants
Fix issue #5422.