Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Fix website search issue#5587

Merged
antgamdia merged 2 commits into
vmware-tanzu:mainfrom
antgamdia:hotfix-website-search
Oct 28, 2022
Merged

Fix website search issue#5587
antgamdia merged 2 commits into
vmware-tanzu:mainfrom
antgamdia:hotfix-website-search

Conversation

@antgamdia
Copy link
Copy Markdown
Contributor

Description of the change

This PR is a hotfix for a bug introduced at #5579: the searchbox init code was moved to a static folder, which is unable to retrieve the values from the site params. Therefore, the API key is literally .Site.Params.docs_search_api_key instead of the replaced value.

Also, squeezing a minor fix to prevent Kubeapps Kubeapps ... to appear in the descriptions.

Benefits

Search will work again

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 28, 2022

Deploy Preview for kubeapps-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f43296
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/635bbab07ba42a000936e9b3
😎 Deploy Preview https://deploy-preview-5587--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antgamdia
Copy link
Copy Markdown
Contributor Author

Rubber stamping as the fix works in the preview:

image

@antgamdia antgamdia merged commit 0d89628 into vmware-tanzu:main Oct 28, 2022
@antgamdia antgamdia deleted the hotfix-website-search branch October 28, 2022 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants