This repository was archived by the owner on Jan 13, 2026. It is now read-only.
fix for [Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871 #5714
Merged
gfichtenholt merged 16 commits intoNov 29, 2022
Merged
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Contributor
Author
|
Dimitri please review when you get a chance. The changes should look pretty familiar to what you just did with helm plugin |
dlaloue-vmware
suggested changes
Nov 29, 2022
Contributor
dlaloue-vmware
left a comment
dlaloue-vmware
left a comment
There was a problem hiding this comment.
code wise, i think there is no problem (just a few notes).
but can you check the change to the schema, this might be an issue.
dlaloue-vmware
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved secret management functionality into a separate file repo_auth.go