Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

Update TagList and helm check to use oras client.#6760

Merged
absoludity merged 1 commit into
mainfrom
6706-sync-public-oci-repo-2
Sep 5, 2023
Merged

Update TagList and helm check to use oras client.#6760
absoludity merged 1 commit into
mainfrom
6706-sync-public-oci-repo-2

Conversation

@absoludity
Copy link
Copy Markdown
Contributor

Description of the change

Switches the TagList and IsHelmChart functions in the syncer to use the standard ORAS client (which handles getting tokens etc.)

Benefits

Use the existing oras client to handle re-fetching tokens on 401s etc., so we don't need to (currently our code doesn't do this at all, which is why we can't currently use a public OCI repo).

Possible drawbacks

Applicable issues

Additional information

More to follow.

Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 5, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 31a09cd
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64f686f00680a60008ead6e2

@absoludity absoludity merged commit f104424 into main Sep 5, 2023
@absoludity absoludity deleted the 6706-sync-public-oci-repo-2 branch September 5, 2023 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants