Support activeDeadlineSeconds for apprepository-controller

[rophy]

Description of the change

Implements #6966

Benefits

AppRepository CronJobs supports activeDeadlineSeconds

Possible drawbacks

I'm not a golang developer, go test passed, not sure if there is anything else I should be testing?

Applicable issues

#6966

[netlify]

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	59c2161
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/6530778676ba690008db1088

[vmwclabot]

@rophy, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[vmwclabot]

@rophy, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[vmwclabot]

@rophy, VMware has approved your signed contributor license agreement.

[absoludity]

I'm not a golang developer, go test passed, not sure if there is anything else I should be testing?

The main thing to test is that if it is set, that the value is used in the spec - which you've done with your update - thanks. The only other thing would be the opposite: to show that if it's not set, it'll be nil - but it's fine as is. +1 and thanks for the improvement!

Note that similar to the --ttl-lifetime-afterfinished-job flag, there is no specific chart option for this but you can set it via the apprepository.extraFlags option.

[absoludity]

I've just pushed a one-liner to fix the error on CI (not sure why it was triggered by this PR, but it's unrelated). EDIT: it's not just this PR - also seeing the same failure in other PRs, eg #6968 .