Skip to content

Change min subnet size to 8 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxiaopei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change min subnet size to 8 #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/yaml/crd/vpc/crd.nsx.vmware.com_subnets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ spec:
ipv4SubnetSize:
description: Size of Subnet based upon estimated workload count.
maximum: 65536
minimum: 16
minimum: 8
type: integer
x-kubernetes-validations:
- message: Value is immutable
Expand Down
2 changes: 1 addition & 1 deletion build/yaml/crd/vpc/crd.nsx.vmware.com_subnetsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
ipv4SubnetSize:
description: Size of Subnet based upon estimated workload count.
maximum: 65536
minimum: 16
minimum: 8
type: integer
x-kubernetes-validations:
- message: Value is immutable
Expand Down
4 changes: 2 additions & 2 deletions docs/ref/apis/vpc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ _Appears in:_

| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `ipv4SubnetSize` _integer_ | Size of Subnet based upon estimated workload count. | | Maximum: 65536 <br />Minimum: 16 <br /> |
| `ipv4SubnetSize` _integer_ | Size of Subnet based upon estimated workload count. | | Maximum: 65536 <br />Minimum: 8 <br /> |
| `accessMode` _[AccessMode](#accessmode)_ | Access mode of Subnet, accessible only from within VPC or from outside VPC. | | Enum: [Private Public PrivateTGW] <br /> |
| `subnetDHCPConfig` _[SubnetDHCPConfig](#subnetdhcpconfig)_ | Subnet DHCP configuration. | | |

Expand Down Expand Up @@ -991,7 +991,7 @@ _Appears in:_
| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `vpcName` _string_ | VPC name of the Subnet. | | |
| `ipv4SubnetSize` _integer_ | Size of Subnet based upon estimated workload count. | | Maximum: 65536 <br />Minimum: 16 <br /> |
| `ipv4SubnetSize` _integer_ | Size of Subnet based upon estimated workload count. | | Maximum: 65536 <br />Minimum: 8 <br /> |
| `accessMode` _[AccessMode](#accessmode)_ | Access mode of Subnet, accessible only from within VPC or from outside VPC. | | Enum: [Private Public PrivateTGW] <br /> |
| `ipAddresses` _string array_ | Subnet CIDRS. | | MaxItems: 2 <br />MinItems: 0 <br /> |
| `subnetDHCPConfig` _[SubnetDHCPConfig](#subnetdhcpconfig)_ | DHCP configuration for Subnet. | | |
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/vpc/v1alpha1/subnet_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type SubnetSpec struct {
VPCName string `json:"vpcName,omitempty"`
// Size of Subnet based upon estimated workload count.
// +kubebuilder:validation:Maximum:=65536
// +kubebuilder:validation:Minimum:=16
// +kubebuilder:validation:Minimum:=8
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
IPv4SubnetSize int `json:"ipv4SubnetSize,omitempty"`
// Access mode of Subnet, accessible only from within VPC or from outside VPC.
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/vpc/v1alpha1/subnetset_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
type SubnetSetSpec struct {
// Size of Subnet based upon estimated workload count.
// +kubebuilder:validation:Maximum:=65536
// +kubebuilder:validation:Minimum:=16
// +kubebuilder:validation:Minimum:=8
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
IPv4SubnetSize int `json:"ipv4SubnetSize,omitempty"`
// Access mode of Subnet, accessible only from within VPC or from outside VPC.
Expand Down
Loading