Add API definition for EAS support#1393
Open
seanpang-vmware wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Add API definition for EAS support#1393seanpang-vmware wants to merge 1 commit intovmware-tanzu:mainfrom
seanpang-vmware wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
|
Please give more info in the commit message. E.g. do not just say "EAS" that no one understands. At least say "extension apiserver". |
seanpang-vmware
force-pushed
the
topic/sp024667/easapi
branch
from
4113eb3 to
5cb1726
Compare
|
I did not check all types in details, but I feel you are not following our formatting conventions, and I wonder why you cannot just copy the types from the nsx-eas repo. |
Add API definition for Extension API Service support 1. ip block usages (referenced nsx-eas definition) 2. subnet dhcp server config stats 3. subnent ip pools 4. vpc ipaddress usages (referenced nsx-eas definition)
seanpang-vmware
force-pushed
the
topic/sp024667/easapi
branch
from
5cb1726 to
2ad97bb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
- Coverage 76.77% 75.35% -1.42%
==========================================
Files 151 151
Lines 21315 21317 +2
==========================================
- Hits 16364 16064 -300
- Misses 3782 3783 +1
- Partials 1169 1470 +301
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add API definition for Extention APIserver support
Add API definition for Extension API Server support, the api definitions contains following resources: