Skip to content

avinetworks.docker included in requirements.txt is a role, not a pypi package #252

@martinbarlow

Description

@martinbarlow

Describe the bug

Hi

in the latest ansible collection requirements.txt includes a role avinetworks.docker,which is not allowed. It should only contain pypi packages. They should be defined in meta/main.yml

https://docs.ansible.com/projects/ansible/latest/playbook_guide/playbooks_reuse_roles.html#using-role-dependencies

Its hard to tell exactly which commit/branch has issue, as there are many!

Its in this commit however.

96323d2#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552

Reproduction steps

$ ansible-galaxy collection install vmware.alb:31.2.2
Starting galaxy collection install process
Process install dependency map
Starting collection install process
Installing 'vmware.alb:31.2.2' to '/home/dm64hay/git/icp-cps-ca/avi-automation/.collections/ansible_collections/vmware/alb'
Downloading https://galaxy.ansible.com/api/v3/plugin/ansible/content/published/collections/artifacts/vmware-alb-31.2.2.tar.gz to /home/dm64hay/.ansible/tmp/ansible-local-4220jd2al12v/tmp9s05uhi_
vmware.alb (31.2.2) was installed successfully

$cat .collections/ansible_collections/vmware/alb/requirements.txt
requests>=2.25.1
pyVmomi>=8.0.2.0.1
pyVim>=3.0.2
beautifulsoup4>=4.9.3
requests_toolbelt
avinetworks.docker%

$pip install -r .collections/ansible_collections/vmware/alb/requirements.txt
Requirement already satisfied: requests>=2.25.1 in ./.venvnew/lib/python3.10/site-packages (from -r .collections/ansible_collections/vmware/alb/requirements.txt (line 1)) (2.25.1)
Requirement already satisfied: pyVmomi>=8.0.2.0.1 in ./.venvnew/lib/python3.10/site-packages (from -r .collections/ansible_collections/vmware/alb/requirements.txt (line 2)) (9.0.0.0)
Requirement already satisfied: pyVim>=3.0.2 in ./.venvnew/lib/python3.10/site-packages (from -r .collections/ansible_collections/vmware/alb/requirements.txt (line 3)) (3.0.2)
Requirement already satisfied: beautifulsoup4>=4.9.3 in ./.venvnew/lib/python3.10/site-packages (from -r .collections/ansible_collections/vmware/alb/requirements.txt (line 4)) (4.9.3)
Requirement already satisfied: requests_toolbelt in ./.venvnew/lib/python3.10/site-packages (from -r .collections/ansible_collections/vmware/alb/requirements.txt (line 5)) (1.0.0)
ERROR: Could not find a version that satisfies the requirement avinetworks.docker (from versions: none)
ERROR: No matching distribution found for avinetworks.docker

Expected behavior

Should successfully install requirements.txt

Additional context

My python is 3.10, but should not matter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions