Added data persistence logic in simulator/model.go and vcsim/main.go#3900
Draft
Manikandan251995 wants to merge 1 commit intovmware:mainfrom
Draft
Added data persistence logic in simulator/model.go and vcsim/main.go#3900Manikandan251995 wants to merge 1 commit intovmware:mainfrom
Manikandan251995 wants to merge 1 commit intovmware:mainfrom
Conversation
Manikandan251995
force-pushed
the
vcsim-persist-data
branch
5 times, most recently
from
5f279eb to
c2d69c0
Compare
Signed-off-by: Manikandan251995 <manikandanmails955@gmail.com>
Manikandan251995
force-pushed
the
vcsim-persist-data
branch
from
c2d69c0 to
ce4aabf
Compare
dougm
reviewed
Nov 19, 2025
Member
dougm
left a comment
dougm
left a comment
There was a problem hiding this comment.
Hi @Manikandan251995 , can you summarize your goals / use-cases here? Looks like quite a bit of code duplicated from the govc object.save command. Seems you want to auto-save?
Contributor
|
Marked as draft since there are merge conflicts and still awaiting a reply from @Manikandan251995. |
Contributor
|
This pull request is stale because it has been open for 90 days with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change.
Closes: #(issue-number)
How Has This Been Tested?
Please describe any manual tests done to verify your changes.
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.