Skip to content

slow down filling out the Okta login screen for Chrome v134 #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuatcasey merged 1 commit into from
Mar 5, 2025
Merged

slow down filling out the Okta login screen for Chrome v134 #2250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/testlib/browsertest/browsertest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2020-2024 the Pinniped contributors. All Rights Reserved.
// Copyright 2020-2025 the Pinniped contributors. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

// Package browsertest provides integration test helpers for our browser-based tests.
Expand Down Expand Up @@ -391,11 +391,18 @@

// Fill in the username and password and click "submit".
t.Logf("logging into %s", cfg.Name)

Check warning on line 394 in test/testlib/browsertest/browsertest.go

View check run for this annotation

Codecov / codecov/patch

test/testlib/browsertest/browsertest.go#L394 

Added line #L394 was not covered by tests
b.SendKeysToFirstMatch(t, cfg.UsernameSelector, upstream.Username)

// The Okta login page has a lot of Javascript on it. Give it a second to catch up after typing the
// username. Hoping that this might help with the test flake that started in Chrome v134 where the
// username and password fields are not filled in correctly.
time.Sleep(1 * time.Second)

Check warning on line 401 in test/testlib/browsertest/browsertest.go

View check run for this annotation

Codecov / codecov/patch

test/testlib/browsertest/browsertest.go#L396-L401 

Added lines #L396 - L401 were not covered by tests
b.SendKeysToFirstMatch(t, cfg.PasswordSelector, upstream.Password)

// The Okta login page has a lot of Javascript on it. Give it a second to catch up after typing the
// username and password. Hoping that this might help with the test flake where the Okta login page
// password. Hoping that this might help with the test flake where the Okta login page

Check warning on line 405 in test/testlib/browsertest/browsertest.go

View check run for this annotation

Codecov / codecov/patch

test/testlib/browsertest/browsertest.go#L405 

Added line #L405 was not covered by tests
// never continues to the next page after trying to click the login button below.
time.Sleep(1 * time.Second)

Expand Down
Loading