Merged
Conversation
annakhm
force-pushed
the
protect-empty-block
branch
from
ebcc887 to
67d4bc4
Compare
Contributor
Author
|
/test-all |
ksamoray
approved these changes
Feb 25, 2025
annakhm
force-pushed
the
protect-empty-block
branch
from
67d4bc4 to
4a7b002
Compare
Contributor
Author
|
/test-all |
Contributor
|
/test-all |
1 similar comment
Contributor
|
/test-all |
Empty block is represeted in schema by slice of size 1 with nil value. Wherever empty block is allowed (no required attributes), we should protect against nil values in slice. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
annakhm
force-pushed
the
protect-empty-block
branch
from
4a7b002 to
b5c4fb6
Compare
Contributor
Author
|
/test-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty block is represeted in schema by slice of size 1 with nil value. Wherever empty block is allowed (no required attributes), we should protect against nil values in slice.