[Feature Complete]Inspection datasources, docs, acceptance tests#327
Merged
ramya-bangera merged 2 commits intomainfrom Jan 11, 2024
Merged
[Feature Complete]Inspection datasources, docs, acceptance tests#327ramya-bangera merged 2 commits intomainfrom
ramya-bangera merged 2 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 25.09% 25.10%
=======================================
Files 191 191
Lines 16480 16482 +2
=======================================
+ Hits 4135 4137 +2
Misses 12131 12131
Partials 214 214 ☔ View full report in Codecov by Sentry. |
GilTeraSky
changed the title
shobha2626
reviewed
Nov 22, 2023
shobha2626
reviewed
Nov 22, 2023
Contributor
|
Please resolve the conflicts |
ramya-bangera
force-pushed
the
feat/inspections
branch
from
f09776b to
d12a06c
Compare
ramya-bangera
changed the title
Contributor
|
Overall LGTM. Please squash the commits into one meaningful message |
Signed-off-by: GilTS <gil@terasky.com>
ramya-bangera
force-pushed
the
feat/inspections
branch
from
71c8f27 to
90e9073
Compare
Contributor
Done |
… rebasing and updated the copyright to 2024 Signed-off-by: Ramya Bangera <bangerar@vmware.com>
ramya-bangera
force-pushed
the
feat/inspections
branch
from
90e9073 to
c6bc92e
Compare
shobha2626
approved these changes
Jan 11, 2024
ankitsny
approved these changes
Jan 11, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the entire implementation of the cluster inspection data sources including tests & docs
Acceptance tests
Terraform output:
