Skip to content

Add jsonencode for clustervariables and nodepool overrides in the tazukubernetescluster resource acceptance tests#351

Merged
ramya-bangera merged 1 commit intomainfrom
bangerar/fix-utkg-test
Dec 15, 2023
Merged

Add jsonencode for clustervariables and nodepool overrides in the tazukubernetescluster resource acceptance tests#351
ramya-bangera merged 1 commit intomainfrom
bangerar/fix-utkg-test

Conversation

@ramya-bangera
Copy link
Copy Markdown
Contributor

  1. What this PR does / why we need it:
    Test fix to include jsonencode for clusterclass variables

  2. Which issue(s) this PR fixes

     (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
     Fixes #
    
  3. Additional information
    Test log:

<testsuite name="github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/testing" tests="0" failures="0" errors="0" id="215" hostname="sc2-10-43-229-72.nimbus.eng.vmware.com" time="0.000" timestamp="2023-12-11T17:14:52Z"></testsuite>
	<testsuite name="github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/tanzukubernetescluster/tests" tests="1" failures="0" errors="0" id="216" hostname="sc2-10-43-229-72.nimbus.eng.vmware.com" time="1806.351" timestamp="2023-12-11T17:44:53Z">
		<testcase name="TestAcceptanceUTKGResource" classname="github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/tanzukubernetescluster/tests" time="1806.320">
			<system-out><![CDATA[    tanzu_kubernetes_cluster_test.go:106: Tanzu kubernetes cluster resource acceptance test complete!]]></system-out>
		</testcase>
		<system-out><![CDATA[	github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/tanzukubernetescluster/tests	coverage: 89.7% of statements]]></system-out>
	</testsuite>
  1. Special notes for your reviewer

…zukubernetescluster resource acceptance tests

Signed-off-by: Ramya Bangera <bangerar@vmware.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ac75a1) 25.28% compared to head (48a7925) 25.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   25.28%   25.28%           
=======================================
  Files         189      189           
  Lines       16345    16345           
=======================================
  Hits         4133     4133           
  Misses      11998    11998           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya-bangera ramya-bangera merged commit f656cb9 into main Dec 15, 2023
@ramya-bangera ramya-bangera deleted the bangerar/fix-utkg-test branch December 15, 2023 06:24
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants