Add support for aks managed identities#359
Conversation
|
@gshaw-pivotal, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
45e5d8f to
d683671
Compare
d683671 to
da2e7ea
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 25.09% 25.24% +0.14%
==========================================
Files 191 191
Lines 16480 16529 +49
==========================================
+ Hits 4135 4172 +37
- Misses 12131 12139 +8
- Partials 214 218 +4 ☔ View full report in Codecov by Sentry. |
da2e7ea to
8edf559
Compare
…ly for aks clusters Signed-off-by: Gavin Shaw <gshaw+github@pivotal.io>
Signed-off-by: Gavin Shaw <gshaw+github@pivotal.io>
8edf559 to
131aeee
Compare
|
@gshaw-pivotal, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gavin Shaw <gshaw+github@pivotal.io>
131aeee to
92c4692
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Support managed identities specification when creating and updating AKS clusters
N/A
When using
terraform applya user can provide aidentity_configsection within the cluster config section of the terraform plan file. Here they can specify whether a system or user assigned managed identity is to be used for the cluster.The default if an
identity_configis not provide will be use a system assigned managed identity.Changes were tested by creating and modifying clusters on Olympus dev stack. Scenarios tested are summarized below:
IDENTITY_TYPE_SYSTEM_ASSIGNED: SUCCESS -> Cluster with system assigned MIIDENTITY_TYPE_USER_ASSIGNEDand no userAssigned struct: ERROR -> No cluster -> Expected behavior, see Terraform test - User assigned identity with no userAssigned struct attachmentIDENTITY_TYPE_USER_ASSIGNEDand empty userAssigned struct: ERROR -> No cluster -> Expected behavior, see Terraform test - User assigned identity with empty struct attachmentIDENTITY_TYPE_USER_ASSIGNEDand populated userAssigned struct, invalid identity: ERROR -> No cluster -> Expected behavior, see Terraform test - User assigned identity with invalid identity attachmentIDENTITY_TYPE_USER_ASSIGNEDand populated userAssigned struct, valid identity: SUCCESS -> Cluster with user assigned MITerraform test - User assigned identity with no userAssigned struct:

Terraform test - User assigned identity with empty struct

Terraform test - User assigned identity with invalid identity
