Fix the NPE issue in provisioner resource/datasource#373
Merged
ramya-bangera merged 1 commit intomainfrom Jan 19, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 25.31% 25.29% -0.03%
==========================================
Files 192 192
Lines 16665 16668 +3
==========================================
- Hits 4219 4216 -3
- Misses 12229 12234 +5
- Partials 217 218 +1 ☔ View full report in Codecov by Sentry. |
shobha2626
previously approved these changes
Jan 19, 2024
The merge-base changed after approval.
Added the fix to return without trying to parse the nil response in case of any error. Signed-off-by: Ramya Bangera <bangerar@vmware.com>
12ba2d8 to
25c9eca
Compare
shobha2626
approved these changes
Jan 19, 2024
ankitsny
approved these changes
Jan 19, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added the fix to return without trying to parse the nil response in case of any error.
Which issue(s) this PR fixes
Internal Jira
Additional information
Special notes for your reviewer