Implement fix for failing AKS acceptance/mock test#377
Merged
gshaw-pivotal merged 1 commit intomainfrom Feb 8, 2024
Merged
Conversation
gshaw-pivotal
force-pushed
the
acceptance-test-fix-for-aks
branch
from
74cd0a6 to
94eb067
Compare
Signed-off-by: Gavin Shaw <gshaw+github@pivotal.io>
gshaw-pivotal
force-pushed
the
acceptance-test-fix-for-aks
branch
from
94eb067 to
9be22e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 25.40% 25.40%
=======================================
Files 195 195
Lines 16784 16784
=======================================
Hits 4264 4264
Misses 12302 12302
Partials 218 218 ☔ View full report in Codecov by Sentry. |
gshaw-pivotal
changed the title
ramya-bangera
approved these changes
Feb 8, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an AKS acceptance/mock test that was broken when managed identity work was introduced.
As described above, the 'TestAccAksCluster_basics' test was broken by the introduction of supporting managed identities for AKS clusters. This MR fixes said failing test.
Tested both against a mock and real stack (by setting 'ENABLE_AKS_ENV_TEST' env variable).