Skip to content

Fix x509 issues#408

Merged
sbasu31 merged 1 commit intovmware:mainfrom
warroyo:cert-fix
Aug 6, 2024
Merged

Fix x509 issues#408
sbasu31 merged 1 commit intovmware:mainfrom
warroyo:cert-fix

Conversation

@warroyo
Copy link
Copy Markdown
Contributor

@warroyo warroyo commented Aug 5, 2024

  1. What this PR does / why we need it:

This removes the hard coded root cert and allows the system store to be used to trust certs unless root CAs are explicitly provided

Signed-off-by: Will Arroyo <warroyo7199008@gmail.com>
@ysineil
Copy link
Copy Markdown

ysineil commented Aug 5, 2024

please merge, we're experiencing this issue.

@warroyo
Copy link
Copy Markdown
Contributor Author

warroyo commented Aug 5, 2024

@ysineil a quick workaround until this is merged is to set insecure_allow_unverified_ssl=true in the provider config.

@ysineil
Copy link
Copy Markdown

ysineil commented Aug 5, 2024

confirmed

@GantzGit
Copy link
Copy Markdown

GantzGit commented Aug 5, 2024

fixes #409

@sbasu31 sbasu31 self-requested a review August 6, 2024 05:42
@sbasu31
Copy link
Copy Markdown
Contributor

sbasu31 commented Aug 6, 2024

Approved

@sbasu31 sbasu31 merged commit fd544b7 into vmware:main Aug 6, 2024
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants