fix: incorrect conversion between integer types#467
Merged
tenthirtyam merged 1 commit intomainfrom Dec 4, 2024
Merged
Conversation
To fix the problem, we need to ensure that the value parsed by strconv.ParseUint does not exceed the maximum value that an int can hold before converting it. We can achieve this by adding a bounds check before the conversion. If the value exceeds the maximum value of an int, we should handle it appropriately, such as by setting a default value or returning an error. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
warroyo
approved these changes
Dec 4, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Includes changes to the
internal/resources/tanzupackageinstall/spec/cluster_scope.gofile to enhance the handling of numeric values in theConstructSpecForClusterScopefunction. The most important changes include the addition of a new import and improved handling of large integer values.Improvements to numeric handling:
internal/resources/tanzupackageinstall/spec/cluster_scope.go: Added themathpackage import to enable the use ofmath.MaxInt32for checking the maximum integer value.internal/resources/tanzupackageinstall/spec/cluster_scope.go: Modified theConstructSpecForClusterScopefunction to check if a number exceedsmath.MaxInt32and handle it appropriately by storing it as a string instead of converting it to anint.Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
https://github.com/vmware/terraform-provider-tanzu-mission-control/security/code-scanning/1
Additional Information