Skip to content

fixing datasource schema for tanzu kubernetes clusters and adding generic helper#479

Merged
vivgoyal merged 2 commits intomainfrom
datasource-helpers
Mar 25, 2025
Merged

fixing datasource schema for tanzu kubernetes clusters and adding generic helper#479
vivgoyal merged 2 commits intomainfrom
datasource-helpers

Conversation

@warroyo
Copy link
Copy Markdown
Contributor

@warroyo warroyo commented Dec 13, 2024

Summary

This PR fixes an issue where the data source for tanzu kubernetes clusters had fields that were not being marked as computed and could not be used in other parts of the terraform code.

This adds a helper that modifies the schema to be specific to datasources . This helper can be re-used for other datasources. The helper is also implemented in the tanzu_kubernetes_cluster datasources

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

no documentation needed since there is no change to the user experience. Tested creating a cluster and getting the data back using the datatsource and ensuring that it could be referenced before the cluster exists

Issue References

Additional Information

@github-actions github-actions bot added chore Chore provider Provider needs-review Needs Review labels Dec 13, 2024
tenthirtyam
tenthirtyam previously approved these changes Dec 16, 2024
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: warroyo <warroyo7199008@gmail.com>
@vivgoyal vivgoyal merged commit bedd0ee into main Mar 25, 2025
7 checks passed
@vivgoyal vivgoyal deleted the datasource-helpers branch March 25, 2025 21:50
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 11, 2025
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore provider Provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants