Skip to content

Control plane overrides for VKS 3.2#488

Merged
vivgoyal merged 1 commit intovmware:mainfrom
hxietkg:vmware/hxie/cp-overrides
Mar 7, 2025
Merged

Control plane overrides for VKS 3.2#488
vivgoyal merged 1 commit intovmware:mainfrom
hxietkg:vmware/hxie/cp-overrides

Conversation

@hxietkg
Copy link
Copy Markdown
Contributor

@hxietkg hxietkg commented Jan 7, 2025

Summary

To support overrides variables in control plane, which is a new feature for VKS 3.2.0

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

image
image

@github-actions github-actions bot added documentation Documentation provider Provider needs-review Needs Review labels Jan 7, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 19.95%. Comparing base (3578fd2) to head (97921be).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/resources/tanzukubernetescluster/helper.go 0.00% 23 Missing ⚠️
...anzukubernetescluster/tests/resource_tf_configs.go 0.00% 3 Missing ⚠️
...netescluster/resource_tanzu_kuberenetes_cluster.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3578fd2) and HEAD (97921be). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3578fd2) HEAD (97921be)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   25.23%   19.95%   -5.29%     
==========================================
  Files         195      264      +69     
  Lines       16908    23648    +6740     
==========================================
+ Hits         4267     4719     +452     
- Misses      12423    18715    +6292     
+ Partials      218      214       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hxietkg hxietkg force-pushed the vmware/hxie/cp-overrides branch 2 times, most recently from 7988d15 to 3b120ec Compare January 8, 2025 02:50
Signed-off-by: Hongsheng Xie <hongsheng.xie@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the vmware/hxie/cp-overrides branch from 3b120ec to 97921be Compare March 6, 2025 19:17
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased too.

@vivgoyal vivgoyal merged commit 3e51062 into vmware:main Mar 7, 2025
3 checks passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Mar 11, 2025
@hxietkg hxietkg deleted the vmware/hxie/cp-overrides branch April 5, 2025 07:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 6, 2025

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation provider Provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants