docs: update naming style from imperative to declarative#491
docs: update naming style from imperative to declarative#491tenthirtyam merged 1 commit intovmware:mainfrom stevewallone:declarative-terraform
Conversation
|
@stevewallone, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 25.23% 19.96% -5.27%
==========================================
Files 195 264 +69
Lines 16908 23632 +6724
==========================================
+ Hits 4267 4719 +452
- Misses 12423 18699 +6276
+ Partials 218 214 -4 ☔ View full report in Codecov by Sentry. |
|
@vivgoyal giving this a bump for a review. |
Signed-off-by: Steve Wall <steven.wall@capstonec.com>
|
@vivgoyal Sorry to bother you with this, but if you could give this a review that would great! |
|
Giving a bump for visibility. @vivgoyal would a bottle of scotch help? Maybe bourbon? Some good wine? I'll do whatever it takes. ;-) |
|
Hi @stevewallone 👋🏻 - Vivek is out of office currently, but I've shared a reminder internally for return. |
|
Sorry for the delay. Just came back from PTO today. |
|
Thanks for making this happen! Should I move forward deleting the branch? |
|
Yep! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
The terraform files use an imperative style, i.e. create_tkg_cluster. The convention is to use a declarative style that doesn't imply an actions, i.e. tkg_cluster.
Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Resolves #482
Additional Information