Skip to content

chore: remove redundant code and update build tags#595

Merged
tenthirtyam merged 1 commit intomainfrom
chore/lint-fixes
Nov 17, 2025
Merged

chore: remove redundant code and update build tags#595
tenthirtyam merged 1 commit intomainfrom
chore/lint-fixes

Conversation

@tenthirtyam
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam commented Nov 17, 2025

Summary

Ran golangci-lint run --fix to:

  • Eliminates unnecessary blank lines and redundant code across multiple files to improve readability and maintainability.
  • Updates Go build tags by removing legacy +build comments, standardizing on //go:build syntax for test files.

Updates linter configuration to use wsl_v5 with custom settings in .golangci.yml.

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

@tenthirtyam tenthirtyam self-assigned this Nov 17, 2025
@tenthirtyam tenthirtyam added the chore Chore label Nov 17, 2025
@github-actions github-actions bot added dependencies Dependencies provider Provider needs-review Needs Review labels Nov 17, 2025
Ran `golangci-lint run --fix` to:
- Eliminates unnecessary blank lines and redundant code across multiple files to improve readability and maintainability.
- Updates Go build tags by removing legacy `+build` comments, standardizing on `//go:build` syntax for test files.

Updates linter configuration to use `wsl_v5` with custom settings in `.golangci.yml`.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam marked this pull request as ready for review November 17, 2025 15:54
Copilot AI review requested due to automatic review settings November 17, 2025 15:54
@tenthirtyam tenthirtyam merged commit cf46744 into main Nov 17, 2025
12 checks passed
@tenthirtyam tenthirtyam deleted the chore/lint-fixes branch November 17, 2025 15:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs automated code cleanup by removing redundant code and standardizing build tags across the codebase. The changes improve code maintainability and readability while ensuring compliance with modern Go conventions.

  • Removes legacy // +build comments from 60+ test files, standardizing on //go:build syntax
  • Eliminates unnecessary blank lines throughout the codebase to improve readability
  • Updates linter configuration to use wsl_v5 with custom settings for whitespace management

Reviewed Changes

Copilot reviewed 104 out of 104 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Multiple test files (60+ files) Removed legacy // +build build tag comments, keeping only //go:build directives
Multiple Go source files Removed unnecessary blank lines between variable declarations and error checks to improve code flow
.golangci.yml Updated linter from wsl to wsl_v5 with custom configuration and added staticcheck SA1019 exclusion
internal/models/kubernetessecret/clustergroup/*.go Reformatted import statements to use multi-line format
Test files in internal/resources/*/tests/ Added blank lines in test functions to improve readability between test step blocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tenthirtyam tenthirtyam added this to the .next milestone Dec 1, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Dec 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore dependencies Dependencies provider Provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants