Skip to content

Allowing tls config to be passed to sm login#596

Merged
tenthirtyam merged 2 commits intovmware:mainfrom
IndulekhaPrathapan:sm-missingtlsconfig
Nov 24, 2025
Merged

Allowing tls config to be passed to sm login#596
tenthirtyam merged 2 commits intovmware:mainfrom
IndulekhaPrathapan:sm-missingtlsconfig

Conversation

@IndulekhaPrathapan
Copy link
Copy Markdown
Contributor

@IndulekhaPrathapan IndulekhaPrathapan commented Nov 18, 2025

Summary

Type

  • [ X] This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • [x ] No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

TMC-69282

Additional Information

The TMC terraform provider does not work with the ca_file and ca_cert provider options for TMC-SM.

Most customers use internally signed certs with their own CA for TMC SM. This issue prevents them from being able to connect to TMC SM with the provider.

@github-actions github-actions bot added provider Provider needs-review Needs Review labels Nov 18, 2025
@IndulekhaPrathapan IndulekhaPrathapan changed the title DRAFT:Allowing tls config to be passed to sm login Allowing tls config to be passed to sm login Nov 19, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.54%. Comparing base (3578fd2) to head (56c0ab6).
⚠️ Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
internal/authctx/selfmanaged.go 0.00% 11 Missing ⚠️
internal/authctx/client.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3578fd2) and HEAD (56c0ab6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3578fd2) HEAD (56c0ab6)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   25.23%   17.54%   -7.70%     
==========================================
  Files         195      264      +69     
  Lines       16908    17661     +753     
==========================================
- Hits         4267     3098    -1169     
- Misses      12423    14365    +1942     
+ Partials      218      198      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tenthirtyam tenthirtyam merged commit eb6ee87 into vmware:main Nov 24, 2025
3 checks passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Nov 24, 2025
@tenthirtyam tenthirtyam added this to the .next milestone Dec 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

provider Provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants