Skip to content

vcfa_provider_gateway + vcfa_tier0_gateway#10

Merged
Didainius merged 16 commits intovmware:mainfrom
Didainius:vcfa_provider_gateway
Jan 23, 2025
Merged

vcfa_provider_gateway + vcfa_tier0_gateway#10
Didainius merged 16 commits intovmware:mainfrom
Didainius:vcfa_provider_gateway

Conversation

@Didainius
Copy link
Copy Markdown
Contributor

@Didainius Didainius commented Jan 22, 2025

Adds vcfa_provider_gateway resource + data source and vcfa_tier0_gateway data source

TestAccVcfaProviderGateway passes

Ref:

Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
Copy link
Copy Markdown
Contributor Author

Cross referencing #9 (comment) to patch it here

Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius Didainius force-pushed the vcfa_provider_gateway branch from c696b5b to 75116ab Compare January 23, 2025 09:48
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius Didainius force-pushed the vcfa_provider_gateway branch from 75116ab to 4a8a884 Compare January 23, 2025 10:01
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius Didainius marked this pull request as ready for review January 23, 2025 12:13
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Copy link
Copy Markdown

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried manually, but without corner cases.

Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things

Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius Didainius merged commit ee6fcd7 into vmware:main Jan 23, 2025
@Didainius Didainius deleted the vcfa_provider_gateway branch January 23, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants