Add vcfa_content_library resource and data source + vcfa_storage_class data source + vcfa_region_storage_policy data source#12
Merged
adambarreiro merged 21 commits intovmware:mainfrom Jan 24, 2025
Conversation
adambarreiro
changed the title
added 10 commits
January 23, 2025 11:50
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
commented
Jan 23, 2025
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
reviewed
Jan 23, 2025
Contributor
Didainius
left a comment
Didainius
left a comment
There was a problem hiding this comment.
A few immediate comments
added 5 commits
January 23, 2025 15:24
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
approved these changes
Jan 23, 2025
added 3 commits
January 23, 2025 16:38
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
vcfa_content_libraryresource + data source and complementaryvcfa_storage_class,vcfa_region_storage_policydata sources.Disclaimer: Tenant content libraries are not tested yet, as it requires modyfing
vcfa_org_vdcand PR would be quite big. This feature will come on next PRs.Ref: