Merged
Conversation
added 10 commits
January 31, 2025 10:08
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 19 commits
January 31, 2025 13:32
…rraform-provider-vcfa into fix-ldap Signed-off-by: abarreiro <abarreiro@vmware.com>
…rraform-provider-vcfa into fix-ldap Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 11 commits
February 17, 2025 16:43
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 2 commits
February 24, 2025 10:44
Didainius
approved these changes
Feb 25, 2025
Contributor
Didainius
left a comment
Didainius
left a comment
There was a problem hiding this comment.
lgtm
Only one consideration inline.
Automated and manual testing worked
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
reviewed
Feb 26, 2025
lvirbalas
left a comment
lvirbalas
left a comment
There was a problem hiding this comment.
An ask on most of the For example, statements in the Description fields.
added 3 commits
February 27, 2025 10:43
lvirbalas
reviewed
Mar 5, 2025
| * `given_name` - (Required) LDAP attribute to use for the user's given name. For example, the _"givenName"_ attribute | ||
| * `surname` - (Required) LDAP attribute to use for the user's surname. For example, the _"sn"_ attribute | ||
| * `telephone` - (Required) LDAP attribute to use for the user's telephone number. For example, the _"telephoneNumber"_ attribute | ||
| * `group_membership_identifier` - (Required) LDAP attribute that identifies a user as a member of a group. For example, the _"dn"_ attribute |
There was a problem hiding this comment.
This is a late comment about group_back_link_identifier param below. I just noticed that though docs say it's optional, it actually fails if you don't provide it:
│ Error: Missing required argument
│
│ on main.tf line 395, in resource "vcfa_org_ldap" "my-org-ldap":
│ 395: group_attributes {
│
│ The argument "group_membership_identifier" is required, but no definition was found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
vcfa_provider_ldapresource and data source to support configuring LDAP in the Provider (System) organization.This complements
vcfa_org_ldapwhich is just for regular Organizations (tenants).Also:
auto_trust_certificateargument to automatically trust SSL certificates from LDAPS.passwordattribute from LDAP data sources