Use a container ClientContainer for meta interface{} to extend #29
Merged
Didainius merged 11 commits intovmware:mainfrom Feb 4, 2025
Merged
Use a container ClientContainer for meta interface{} to extend #29Didainius merged 11 commits intovmware:mainfrom
ClientContainer for meta interface{} to extend #29Didainius merged 11 commits intovmware:mainfrom
Conversation
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
… 'Version' Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
lvirbalas
reviewed
Feb 4, 2025
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
MetaContainer for meta interface{} to extend ClientContainer for meta interface{} to extend
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
adambarreiro
reviewed
Feb 4, 2025
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
lvirbalas
approved these changes
Feb 4, 2025
lvirbalas
left a comment
There was a problem hiding this comment.
Looks great, just PR still mentions "meta" :)
Contributor
Author
The parts of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code contains many search/replace things, but core change is in
provider.goThe root thing is that the
meta interface{}attribute will betype ClientContainerinstead of*VCDClient.Instead it is:
Such approach allows us to expand the
metaargument that is used in all SDK method with additional structures that might be required.The difference for consumption is that it becomes:
instead of:
in each SDK consuming
Tests passed without any panics which should confirm that there are no missing replacements.