provider.url should not require API path#47
Merged
Didainius merged 8 commits intovmware:mainfrom Feb 27, 2025
Merged
Conversation
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
adambarreiro
approved these changes
Feb 27, 2025
lvirbalas
approved these changes
Feb 27, 2025
lvirbalas
left a comment
lvirbalas
left a comment
There was a problem hiding this comment.
Nice!! Let's just mention the exact /tm/api instead of /api in PR description to reflect the change precisely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
urlfield inproviderconfiguration does not require specifying API endpoint suffix/tm/apiwhich is backed by vmware/go-vcloud-director#765 changeTests are passing.