Fix Org Settings + Org LDAP destroy issues#61
Merged
adambarreiro merged 4 commits intovmware:mainfrom Mar 18, 2025
Merged
Conversation
added 2 commits
March 18, 2025 12:46
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
approved these changes
Mar 18, 2025
lvirbalas
approved these changes
Mar 18, 2025
Signed-off-by: abarreiro <abarreiro@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these operations are run concurrently (they only depend on
org_id, so they always will), there's a high probability that the target Organization gets completely bricked (can't read, update, delete nor access TP).The affected resources are:
When creating/updating/deleting these at the same time, an error can occur and the target Organization gets bricked.
This PR adds a mutex to prevent this issue.