Merged
Conversation
DeltaMichael
approved these changes
May 17, 2023
yonitoo
approved these changes
May 17, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
force-pushed
the
person/murphp15/use_newest_python_client_library
branch
from
210bf56 to
430bf1e
Compare
yonitoo
pushed a commit
that referenced
this pull request
May 18, 2023
# Why We were using a version of the python client generator that had a few bugs in it. I opened tickets and they have fixed the bugs. in this PR #2076 I released the new version. # What Make a few small changes to make it compatible with the latest version # How has this been tested ran tests locally Signed-off-by: murphp15 <murphp15@tcd.ie>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We were using a version of the python client generator that had a few bugs in it. I opened tickets and they have fixed the bugs. in this PR #2076 I released the new version.
What
Make a few small changes to make it compatible with the latest version
How has this been tested
ran tests locally