frontend: add null checks for optional configs#2193
Merged
DeltaMichael merged 1 commit intomainfrom Jun 2, 2023
Merged
Conversation
Why Missing configs cause the UI to fail on startup What Add null checks for the ignoreComponents and ignoreRoutes configs How has this been tested Locally What kind of change is this Feature, non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
yonitoo
approved these changes
Jun 2, 2023
ivakoleva
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Missing configs cause the UI to fail on startup
What
Add null checks for the ignoreComponents and
ignoreRoutes configs
How has this been tested
Locally
What kind of change is this
Feature, non-breaking